Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<All paths Interface>: <Correct number of lessons in all paths interface> #4542

Closed
3 tasks done
BodiAli opened this issue May 25, 2024 · 8 comments · Fixed by #4575
Closed
3 tasks done

<All paths Interface>: <Correct number of lessons in all paths interface> #4542

BodiAli opened this issue May 25, 2024 · 8 comments · Fixed by #4575
Assignees

Comments

@BodiAli
Copy link
Contributor

BodiAli commented May 25, 2024

Checks

Describe your suggestion

Inside the all paths interface especially the JavaScript course the number of lessons do not match the actual number of lessons

Path

Other / NA

Lesson Url

https://www.theodinproject.com/paths/full-stack-javascript

(Optional) Discord Name

bodiali.

(Optional) Additional Comments

No response

@madaooftheblues
Copy link

madaooftheblues commented May 26, 2024

I think this belongs to theodinproject repo.

@MaoShizhong MaoShizhong transferred this issue from TheOdinProject/curriculum May 26, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog / Ideas in Main Site May 26, 2024
@MaoShizhong
Copy link
Contributor

Transferred to web app repo due to the subject matter.

@BodiAli Could you elaborate with some examples? The JavaScript course you linked shows 29 lessons and 12 projects, and within it, I count 29 lessons and 12 projects.

@BodiAli
Copy link
Contributor Author

BodiAli commented May 31, 2024

@MaoShizhong
I'll drop in some screenshots, maybe the computer science part is what makes the number of lessons more than 29 lessons for me, I counted them
Here is the all paths interface
Screenshot from 2024-05-31 22-17-46

Screenshot from 2024-05-31 22-18-05

And here is the dashboard interface
Screenshot from 2024-05-31 22-18-49

@MaoShizhong
Copy link
Contributor

@BodiAli I see. The dashboard interface combines lessons and projects into one count (29 lessons + 12 projects = 41, 23 React lessons + 3 React projects = 26 etc.)

I'll see what the team thinks about the use of the word "lessons" in the Dashboard overview, or potentially showing the split lesson/project counts there instead of the combined count.

@BodiAli
Copy link
Contributor Author

BodiAli commented May 31, 2024

@MaoShizhong Oh that makes a lot of sense thank you for clarifying

@MaoShizhong
Copy link
Contributor

@BodiAli It would make sense for our dashboard view to display the split lesson/project counts for each course, exactly like how the current "All paths" version displays things.

I know you checked the "assignment" box, but want to check with you first since you may not have been expecting this to be a Ruby on Rails/ERB thing, given you posted this in the curriculum repo.

If you'd still like to be assigned to this, let me know, but if not then that's also completely fine.

@BodiAli
Copy link
Contributor Author

BodiAli commented Jun 10, 2024

@MaoShizhong I would love to be assigned to this, however just so you know I did not take the ruby course since you mentioned it

@MaoShizhong
Copy link
Contributor

MaoShizhong commented Jun 17, 2024

I'll assign you to this @BodiAli.
You can follow our wiki instructions for setting up and locally deploying the TOP Rails app.
Once that's all up and running, you'll need to edit the ERB template for the course list in the dashboard interface so that the courses there use the split lesson/project counts that's currently used in the other interfaces.

Acceptance criteria

  • Dashboard course list uses the same split lesson/project counts as other course list interfaces
  • Split count is positioned and aligned well, just as the previous joint count was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants