-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: courses use the split lesson/project counts #4575
Feature: courses use the split lesson/project counts #4575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @BodiAli!
We should be consistent with how we display these counts. Can we use the same design with icons as we have on the course card with this please?
We can extract the count markup to a partial to easily use it in both screens, and make sure any future updates will be be applied everywhere its used.
Can you clarify more on what you mean? @KevinMulhern Is it the icons for lessons and projects that must be added? |
No problem @BodiAli, yep, pretty much just the icons. We want the counts to look exactly the same on both the course and dashboard screens. |
Anything else I can do? @KevinMulhern |
Sorry for the delay @BodiAli, this looks great! I noticed when there is more than one course, the counts stand out and draw the eye a little too much. I'm not exactly sure what needs to be done, so won't hold up this PR with it and explore that myself. Thanks again for doing this! |
It is an honor to work for this community and website! If you need anything else feel free to ask me :) @KevinMulhern |
Because
The purpose of this PR is that it reduces confusion on how much lessons each course have in the dashboard interface by displaying the number of lessons independently from the number of projects, as I already clarified in this issue I opened: #4542
This PR
Issue
Closes #4542
Additional Information
Pull Request Requirements
keyword: brief description of change
format, using one of the following keywords:Feature
- adds new or amends existing user-facing behaviorChore
- changes that have no user-facing value, refactors, dependency bumps, etcFix
- bug fixesBecause
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section