Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: courses use the split lesson/project counts #4575

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Feature: courses use the split lesson/project counts #4575

merged 3 commits into from
Jun 24, 2024

Conversation

BodiAli
Copy link
Contributor

@BodiAli BodiAli commented Jun 19, 2024

Because

The purpose of this PR is that it reduces confusion on how much lessons each course have in the dashboard interface by displaying the number of lessons independently from the number of projects, as I already clarified in this issue I opened: #4542

This PR

  • Courses viewed in the dashboard now follows the syntax of: "(Number of lessons) Lesson(s) / (Number of projects) Project(s)"

Issue

Closes #4542

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4575 June 19, 2024 23:45 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @BodiAli!

We should be consistent with how we display these counts. Can we use the same design with icons as we have on the course card with this please?

Screenshot 2024-06-20 at 01 03 03

We can extract the count markup to a partial to easily use it in both screens, and make sure any future updates will be be applied everywhere its used.

@BodiAli
Copy link
Contributor Author

BodiAli commented Jun 20, 2024

Can you clarify more on what you mean? @KevinMulhern

Is it the icons for lessons and projects that must be added?

@KevinMulhern
Copy link
Member

No problem @BodiAli, yep, pretty much just the icons. We want the counts to look exactly the same on both the course and dashboard screens.

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4575 June 20, 2024 18:01 Inactive
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4575 June 20, 2024 18:34 Inactive
@BodiAli
Copy link
Contributor Author

BodiAli commented Jun 22, 2024

Anything else I can do? @KevinMulhern

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4575 June 24, 2024 00:35 Inactive
@KevinMulhern
Copy link
Member

Sorry for the delay @BodiAli, this looks great!

I noticed when there is more than one course, the counts stand out and draw the eye a little too much. I'm not exactly sure what needs to be done, so won't hold up this PR with it and explore that myself.

Thanks again for doing this!

@KevinMulhern KevinMulhern merged commit aaa333d into TheOdinProject:main Jun 24, 2024
3 checks passed
@BodiAli
Copy link
Contributor Author

BodiAli commented Jun 24, 2024

It is an honor to work for this community and website! If you need anything else feel free to ask me :) @KevinMulhern

@BodiAli BodiAli deleted the split-lesson-project branch June 24, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<All paths Interface>: <Correct number of lessons in all paths interface>
2 participants