Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove flex from .anchor-link #4508

Merged

Conversation

MaoShizhong
Copy link
Contributor

Because

.anchor-link's flex property was causing rendering issues with <em> children as per TheOdinProject/curriculum#27831.
Only just discovered as #4507 let level 4 headings generate > .anchor-link and that sole heading was the only occurrence of having a child tag splitting up the text content.

Flex is no longer needed for .anchor-link (those headings are the only things that currently use the class).

This PR

  • Removes flex-related properties from .anchor-link
  • Positions .anchor-link:hover::before due to lack of flexbox

Issue

N/A

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

::before positioning handled with non-flex approach
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4508 April 22, 2024 08:01 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks @MaoShizhong

@KevinMulhern KevinMulhern merged commit eb94e67 into TheOdinProject:main Apr 22, 2024
3 checks passed
@MaoShizhong MaoShizhong deleted the fix/remove-flex-from-anchor-link branch April 22, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants