Add feature to disable/enable wrapping on next/prev when cycling through harpoon lists. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption in list:prev and list:next. When true allows prev and next to wrap the harpoon list, when false it will not wrap the harpoon list.
|
Let's not call this harpoon_wrap, but instead ui_nav_wrap, and default value true |
|
Updated the PR. should I update the rest of the formatting that's failing the check to get the format checker to pass? |
|
I'm not enforcing it at a local level yet, this is still exploratory branch. Things are going very good though |
|
I think we should be able to test this. Would you mind creating a failing test? Even if it's just eq(true, false) with a name for me to remember to create it |
|
This feature has been moved. look at #461 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the ask on #341. Allows for people to configure the usage of harpoon_wrap in harpoon:setup(). By default harpoon_wrap is True which keeps the wrapping behavior that already existed.