feat(index-tracking): keep track of the list._index while navigating
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tries to keep track of the `list._index`, by using an `autocmd` for `BufEnter` - which updates the index when entering a harpooned file - and setting the index for different functions inside the list.
This fixes the issue, when there's an empty line inside the quick-menu, which causes everything after the blank line to be forgotten.
This was referenced Apr 11, 2024
For `next()`, the order in which the indices are enumerated is not specified[1], even for numeric indices. Even though it seemed to work, now the encode-/decode-logic uses a numerical `for`-loop, which should keep the order and not miss any items after a `nil`-item. Also, the loop inside the `encode`-function, uses the `list._length` instead of `#items`; which seems to ignore data, when there're 2 or more `nil`-values!? [1] https://www.lua.org/manual/5.1/manual.html#pdf-next
|
Works well for me. Would be nice, if it could get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to keep track of the
list._index, by using anautocmdforBufEnter- which updates the index when entering a harpooned file - and setting the index for different functions inside the list.There's room for improvements, but maybe it can help!?
This also removes the
autocmd Filetype harpoon- which didn't seem to highlight the row?! - and replaces it with passing theindexfor setting the cursor to a row.Maybe there should be an user-option, to enable this?!
This also merges #573, since I felt it's somehow related.