Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added viewports #576

Open
wants to merge 1 commit into
base: harpoon2
Choose a base branch
from
Open

Conversation

lars-vc
Copy link

@lars-vc lars-vc commented Apr 15, 2024

Solving #417
This allows for viewports to be saved when switching files with harpoon.
Important note, I didn't understand how to access the settings table within the select function, so this code isn't triggered until that line is changed.
Could you tell me how to properly access the user's settings?

@maxrzaw
Copy link

maxrzaw commented May 23, 2024

This looks pretty cool. I think the restore_viewport setting would make more sense if it was a setting for a specific list rather than for harpoon. Similar to select_with_nil. This would then allow you to access this setting during select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants