Feat/v2 #157
Merged
Feat/v2 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
===========================================
- Coverage 100.00% 97.43% -2.57%
===========================================
Files 9 11 +2
Lines 136 195 +59
Branches 27 69 +42
===========================================
+ Hits 136 190 +54
- Misses 0 5 +5
Continue to review full report at Codecov.
|
im not fully happy with how the math parser works, but this is in-spec with how jagtag does it, assuming its only for doing actual arithmetic
- do math in the proper order of operations - when math is supplied with non-ints, do string manipulation
|
Resolves #84 |
Closed
this is exactly how original jagtag does it, its even still pemdas compliant!
curtisf
reviewed
Jan 20, 2021
linuswillner
requested changes
Jan 23, 2021
There was a problem hiding this comment.
A few styling nits. Moreover:
- There are currently some significant gaps in code coverage, mainly related around error conditions. These should be covered.
- Unnecessary explicit variable type declarations can be removed to reduce noise.
- The removal of the mandate to use strict boolean expressions can be enacted to reduce a lot of noise around boolean checks. This should in my opinion be done to allow JS truthy/falsy logic to be taken advantage of.
Co-authored-by: Linus Willner <[email protected]>
linuswillner
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the module to pure Typescript, and also fixes some spec violations along the way.