Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor layout, styling and text improvements #875

Closed
5 of 7 tasks
johanstokking opened this issue Jun 28, 2019 · 13 comments
Closed
5 of 7 tasks

Minor layout, styling and text improvements #875

johanstokking opened this issue Jun 28, 2019 · 13 comments
Assignees
Labels
c/console This is related to the Console c/identity server This is related to the Identity Server ui/web This is related to a web interface umbrella This issue needs actionable issues referenced

Comments

@johanstokking
Copy link
Member

johanstokking commented Jun 28, 2019

Summary

Minor layout, style and text improvements for the Console.

Why do we need this?

To make it even more awesome than it already is.

What do you want to see?

Can you do this yourself and submit a Pull Request?

Can review

@johanstokking johanstokking added the c/console This is related to the Console label Jun 28, 2019
@johanstokking johanstokking added this to the July 2019 milestone Jun 28, 2019
@bafonins
Copy link
Contributor

bafonins commented Jul 1, 2019

Increase page size from 5 to 10 (device list in application overview, table can be a bit more condensed) or 20 (list views of applications, devices and gateways)

There is the Devices entry in the side navigation with the list of devices (25 devices per page).

We need alphabetic sorting in lists by default

Shouldnt this be done by IS?

Use consistent Title Case, i.e. "Message _T_ype" in webhook config

Could you provide more context?

@bafonins
Copy link
Contributor

bafonins commented Jul 1, 2019

Add "connected" indicator to gateway list by checking GS connection stats

and

Increase page size from 5 to 10 (device list in application overview, table can be a bit more condensed) or 20 (list views of applications, devices and gateways)

I can agree that showing the connection status for gateways is nice, however do we really want to make 5-20 calls to fetch the stats on every page change?

@johanstokking johanstokking added the in progress We're working on it label Jul 1, 2019
@johanstokking
Copy link
Member Author

Increase page size from 5 to 10 (device list in application overview, table can be a bit more condensed) or 20 (list views of applications, devices and gateways)

There is the Devices entry in the side navigation with the list of devices (25 devices per page).

OK, but not the applications and gateways, see e.g.

Screenshot 2019-07-01 at 14 32 44

We need alphabetic sorting in lists by default

Shouldnt this be done by IS?

Yeah it's the responsibility of where pagination happens, because we first need to sort before we can paginate. I don't think we should go as far as sorting by a selected column, but at least by one entity "primary" column (i.e. ID).

Add "connected" indicator to gateway list by checking GS connection stats

and

Increase page size from 5 to 10 (device list in application overview, table can be a bit more condensed) or 20 (list views of applications, devices and gateways)

I can agree that showing the connection status for gateways is nice, however do we really want to make 5-20 calls to fetch the stats on every page change?

Yeah I think so. These calls are cheap and we could optimize it later by grouping stats check per GS.

@bafonins
Copy link
Contributor

bafonins commented Jul 1, 2019

OK, but not the applications and gateways, see e.g.

So, shall we increase page size for applications and gateways to 10? cc @kschiffer

@htdvisser htdvisser self-assigned this Jul 1, 2019
@htdvisser htdvisser added the c/identity server This is related to the Identity Server label Jul 1, 2019
@htdvisser
Copy link
Contributor

I can look into sorting of those listings

@johanstokking johanstokking added the umbrella This issue needs actionable issues referenced label Jul 1, 2019
@kschiffer
Copy link
Member

OK, but not the applications and gateways, see e.g.

So, shall we increase page size for applications and gateways to 10? cc @kschiffer

Yes, I think 10 is a good default. Let's also use a unified constant for this.

@kschiffer
Copy link
Member

Move API key name to first column

See my comment on improving the list display of api keys as a whole:

The ID value is very unhelpful IMO. I don't see any user scanning the table by a cryptic hash value. If we can, we should really sort by creation date or the name value. We might even consider making the name field mandatory, or setting default values like API Key 1, which I would recommend. We can then hide or at least abbreviate the ID field in the table view (that is, if there is no essential use of the ID value that I have missed).

If there's no objection I would like to solve it this way.

@htdvisser
Copy link
Contributor

The ID is the middle part of the API key, so if a user has an API key, they can see the key's rights by finding that same ID in the list.

I would propose to leave things the way they are (so sort by ID) until we have #316 which allows us to sort by fields other than ID.

@johanstokking
Copy link
Member Author

@kschiffer I think 10 is too little. The Console should be informative. If it doesn't fit, consider making the table more condense. I'd say at least 20 but maybe 25 or 30 items.

@kschiffer
Copy link
Member

Please move this to #907.

This was referenced Jul 3, 2019
@johanstokking johanstokking added quickfix ui/web This is related to a web interface and removed quickfix labels Jul 19, 2019
@htdvisser htdvisser modified the milestones: July 2019, August 2019 Aug 1, 2019
@htdvisser htdvisser removed their assignment Aug 13, 2019
@bafonins bafonins modified the milestones: August 2019, September 2019 Aug 27, 2019
@johanstokking
Copy link
Member Author

Please address also replace hardcoded The Things Stack Account by {siteName} Account

@kschiffer
Copy link
Member

Please address also replace hardcoded The Things Stack Account by {siteName} Account

via #1323

@kschiffer kschiffer removed the in progress We're working on it label Sep 24, 2019
@kschiffer
Copy link
Member

Closing in favor of actionable issues (see OP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console c/identity server This is related to the Identity Server ui/web This is related to a web interface umbrella This issue needs actionable issues referenced
Projects
None yet
Development

No branches or pull requests

4 participants