-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor layout, styling and text improvements #875
Comments
There is the
Shouldnt this be done by IS?
Could you provide more context? |
and
I can agree that showing the connection status for gateways is nice, however do we really want to make 5-20 calls to fetch the stats on every page change? |
OK, but not the applications and gateways, see e.g.
Yeah it's the responsibility of where pagination happens, because we first need to sort before we can paginate. I don't think we should go as far as sorting by a selected column, but at least by one entity "primary" column (i.e. ID).
Yeah I think so. These calls are cheap and we could optimize it later by grouping stats check per GS. |
So, shall we increase page size for applications and gateways to 10? cc @kschiffer |
I can look into sorting of those listings |
Yes, I think 10 is a good default. Let's also use a unified constant for this. |
See my comment on improving the list display of api keys as a whole:
If there's no objection I would like to solve it this way. |
The ID is the middle part of the API key, so if a user has an API key, they can see the key's rights by finding that same ID in the list. I would propose to leave things the way they are (so sort by ID) until we have #316 which allows us to sort by fields other than ID. |
@kschiffer I think 10 is too little. The Console should be informative. If it doesn't fit, consider making the table more condense. I'd say at least 20 but maybe 25 or 30 items. |
Please move this to #907. |
Please address also replace hardcoded |
via #1323 |
Closing in favor of actionable issues (see OP). |
Summary
Minor layout, style and text improvements for the Console.
Why do we need this?
To make it even more awesome than it already is.
What do you want to see?
Can you do this yourself and submit a Pull Request?
Can review
The text was updated successfully, but these errors were encountered: