Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase page size of entity tables to 20 #907

Closed
kschiffer opened this issue Jul 2, 2019 · 2 comments · Fixed by #1020
Closed

Increase page size of entity tables to 20 #907

kschiffer opened this issue Jul 2, 2019 · 2 comments · Fixed by #1020
Assignees
Labels
c/console This is related to the Console ui/web This is related to a web interface
Milestone

Comments

@kschiffer
Copy link
Contributor

kschiffer commented Jul 2, 2019

Summary

The entity tables currently have a page size of 5, which is a bit low. 20 is a better value that will fill a usual browser window (16:9) better.

Why do we need this?

Improve UX. Page sizes that are too small are hard to navigate through. Whether 20 is indeed the optimal default needs some progressive insight.

What is already there? What do you see now?

  • Functionality to set the page size in our <Pagination /> component.
  • Various default value constants for page sizes, set to 5

What is missing? What do you want to see?

A unified default value constant of 20 items per page for all entity tables. (Except for the device table in the application overview)

Environment

Console.

How do you propose to implement this?

Trivial.

Can you do this yourself and submit a Pull Request?

Yes.

@kschiffer kschiffer added the c/console This is related to the Console label Jul 2, 2019
@kschiffer kschiffer added this to the July 2019 milestone Jul 2, 2019
@kschiffer kschiffer self-assigned this Jul 2, 2019
@johanstokking
Copy link
Member

I'm opting for 20, 25 or 30, potentially making the table a bit more condense.

@kschiffer
Copy link
Contributor Author

Ok, let's use 20 then. Anything higher makes the page already quite long. We can later provide a Show all items button.

@kschiffer kschiffer changed the title Increase page size of entity tables to 10 Increase page size of entity tables to 20 Jul 3, 2019
@kschiffer kschiffer assigned mjamescompton and unassigned kschiffer Jul 19, 2019
@johanstokking johanstokking added quickfix ui/web This is related to a web interface and removed quickfix labels Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants