Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application e2e tests #3650

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add application e2e tests #3650

merged 1 commit into from
Jan 11, 2021

Conversation

asmulko
Copy link
Contributor

@asmulko asmulko commented Jan 10, 2021

Summary

References #3606

Changes

  • Added application read, edit and delete tests

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@asmulko asmulko added the c/console This is related to the Console label Jan 10, 2021
@asmulko asmulko added this to the Backlog milestone Jan 10, 2021
@asmulko asmulko self-assigned this Jan 10, 2021
@asmulko asmulko mentioned this pull request Jan 10, 2021
Closed
65 tasks
@asmulko asmulko force-pushed the issue/3606-application-e2e-tests branch from cfd0071 to 5a30b20 Compare January 10, 2021 11:06
@asmulko asmulko force-pushed the issue/3606-application-e2e-tests branch from 5a30b20 to e161338 Compare January 11, 2021 09:45
@asmulko asmulko requested a review from bafonins January 11, 2021 10:33
bafonins
bafonins approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@bafonins bafonins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please rebase this branch on v3.11 and remove linking tests since app linking is removed in 3.11

@asmulko asmulko changed the base branch from v3.10 to v3.11 January 11, 2021 21:40
@asmulko asmulko force-pushed the issue/3606-application-e2e-tests branch from e161338 to 99669c9 Compare January 11, 2021 21:40
@asmulko asmulko merged commit 06df05a into v3.11 Jan 11, 2021
@asmulko asmulko deleted the issue/3606-application-e2e-tests branch January 11, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bafonins bafonins bafonins approved these changes

@kschiffer kschiffer Awaiting requested review from kschiffer

@pgalic96 pgalic96 Awaiting requested review from pgalic96

Assignees

@asmulko asmulko

Labels
c/console This is related to the Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmulko @bafonins