Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gateway tests #3672

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add gateway tests #3672

merged 1 commit into from
Jan 19, 2021

Conversation

asmulko
Copy link
Contributor

@asmulko asmulko commented Jan 18, 2021

Summary

References #3606

Changes

  • Added gateways e2e tests
  • Added gateways smoke test

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@asmulko asmulko added c/console This is related to the Console ui/web This is related to a web interface labels Jan 18, 2021
@asmulko asmulko added this to the Backlog milestone Jan 18, 2021
@asmulko asmulko self-assigned this Jan 18, 2021
@asmulko asmulko mentioned this pull request Jan 18, 2021
Closed
65 tasks
kschiffer
kschiffer approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my remarks.

cypress/integration/console/gateways/create.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/gateways/create.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/gateways/create.spec.js Show resolved Hide resolved
@asmulko asmulko force-pushed the issue/3606-gateways-e2e-tests branch from 343a724 to e4c90e2 Compare January 19, 2021 11:32
@asmulko asmulko merged commit 6809f44 into v3.11 Jan 19, 2021
@asmulko asmulko deleted the issue/3606-gateways-e2e-tests branch January 19, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@bafonins bafonins Awaiting requested review from bafonins

@pgalic96 pgalic96 Awaiting requested review from pgalic96

Assignees

@asmulko asmulko

Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmulko @kschiffer