Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway location tests #3681

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

asmulko
Copy link
Contributor

@asmulko asmulko commented Jan 20, 2021

Summary

References #3606

Changes

  • Added gateway location e2e tests

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@asmulko asmulko self-assigned this Jan 20, 2021
@github-actions github-actions bot added the ui/web This is related to a web interface label Jan 20, 2021
@asmulko asmulko added the c/console This is related to the Console label Jan 20, 2021
@asmulko asmulko added this to the Backlog milestone Jan 20, 2021
@asmulko asmulko force-pushed the issue/3606-gateway-location-tests branch from 7e51c92 to a839cb2 Compare January 20, 2021 14:39
@asmulko asmulko mentioned this pull request Jan 20, 2021
65 tasks
@asmulko asmulko marked this pull request as ready for review January 20, 2021 15:21
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that checks whether the location can be set by clicking into the map? This should be possible by selecting the map widget and using the .click() method. Note that you can use this method with coordinates.

@asmulko asmulko force-pushed the issue/3606-gateway-location-tests branch from a839cb2 to 583de05 Compare February 8, 2021 13:11
@asmulko
Copy link
Contributor Author

asmulko commented Feb 8, 2021

Can you add a test that checks whether the location can be set by clicking into the map? This should be possible by selecting the map widget and using the .click() method. Note that you can use this method with coordinates.

Thanks for the information on how to do it, I've added the test

@asmulko asmulko force-pushed the issue/3606-gateway-location-tests branch from 583de05 to fd5cd8d Compare February 8, 2021 13:17
@asmulko asmulko merged commit daa7109 into v3.11 Feb 9, 2021
@asmulko asmulko deleted the issue/3606-gateway-location-tests branch February 9, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants