Replace stubs in device views #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
changed the title
bafonins
suggested changes
Mar 27, 2019
| } | ||
|
|
||
| // Add root keys, if available | ||
| if (Object.keys(root_keys) > 0) { |
There was a problem hiding this comment.
Suggested change
| if (Object.keys(root_keys) > 0) { | |
| if (Object.keys(root_keys).length > 0) { |
| list: stubs.devices.list, | ||
| search: stubs.devices.search, | ||
| get: stubs.device.get, | ||
| list: ttnClient.Applications.Devices.getAll.bind(ttnClient.Applications.Devices), |
There was a problem hiding this comment.
Please try building the sdk again and then do
make js.build-dll -B; make js.serve
bafonins
approved these changes
Mar 27, 2019
kschiffer
force-pushed
the
feature/236-webui-device-stub-replacement
branch
from
3234732
to
d0f48c5
Compare
This was referenced Mar 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR replaces the stubs currently in place for displaying device info. There are some small marginally related fixes as well.
Changes:
n/a)<DateTime />component for displaying date/time valuesNotes for Reviewers:
feature/webui-single-device-page, which was already reviewed via Single Device Overview Page (stubbed) #97feature/webui-single-device-pageto merge into master