Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application payload formatters e2e tests #3841

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Add application payload formatters e2e tests #3841

merged 1 commit into from
Mar 9, 2021

Conversation

asmulko
Copy link
Contributor

@asmulko asmulko commented Feb 22, 2021 •
edited
Loading

Summary

References #3606

Changes

  • Added application payload formatters e2e tests
  • Added end device payload formatters e2e tests
  • Added toast notification for end device downlink (use application payload formatter option) save success
  • Renamed several tests according to testing guidelines

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@asmulko asmulko added c/console This is related to the Console ui/web This is related to a web interface labels Feb 22, 2021
@asmulko asmulko added this to the Next Up milestone Feb 22, 2021
@asmulko asmulko self-assigned this Feb 22, 2021
@asmulko asmulko mentioned this pull request Feb 22, 2021
Closed
65 tasks
@asmulko asmulko added in progress We're working on it and removed in progress We're working on it labels Feb 22, 2021
kschiffer
kschiffer suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some small remarks.

cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
@asmulko asmulko force-pushed the issue/3606-payload-formatters-e2e-tests branch from 01c4cae to a079861 Compare March 2, 2021 16:46
@asmulko asmulko force-pushed the issue/3606-payload-formatters-e2e-tests branch 4 times, most recently from 145381b to eb2428f Compare March 2, 2021 17:05
bafonins
bafonins suggested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@bafonins bafonins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

cypress/integration/console/organizations/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/organizations/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
cypress/integration/console/shared/payload-formatters/edit.spec.js Outdated Show resolved Hide resolved
pkg/webui/console/containers/device-payload-formatters/downlink.js Show resolved Hide resolved
@asmulko asmulko force-pushed the issue/3606-payload-formatters-e2e-tests branch from eb2428f to dc6ac56 Compare March 3, 2021 15:56
@asmulko asmulko requested a review from bafonins March 3, 2021 17:13
@asmulko asmulko merged commit 2e193fe into v3.11 Mar 9, 2021
@asmulko asmulko deleted the issue/3606-payload-formatters-e2e-tests branch March 9, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bafonins bafonins bafonins approved these changes

@kschiffer kschiffer kschiffer approved these changes

@pgalic96 pgalic96 Awaiting requested review from pgalic96

Assignees

@asmulko asmulko

Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmulko @kschiffer @bafonins