-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic gateways CRUD operations to js sdk #620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works 👌 . See my comment on unwrapping delete responses.
|
||
// Delete | ||
|
||
async deleteById (id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better if we also unwrap the results here using Marshaler.payloadSingleResponse()
. Same thing with Applications.delete()
.
add basic CRUD operations
unmarshal response for the delete operation
959952e
to
ec8b4e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR adds basic crud operations to the gateways service in js sdk.
References: #26
Changes