Field mask handling fixes #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafonins
approved these changes
May 20, 2019
kschiffer
force-pushed
the
fix/706-sdk-field-mask-extraction
branch
from
70abbce
to
366f4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #706
References #643
Additionally, this adds a utility function to generate
generated/device-entity-map.jsonby a list of valid device field masksgenerated/device-field-masks.json(which for now can easily be extracted viapkg/ttnpb/field_mask_validation.go).Changes
Notes for Reviewers
Please double check if device creation/update is still working with this.