Gateway antenna location settings (without maps) #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
added
c/console
kschiffer
force-pushed
the
feature/643-device-location-settings
branch
2 times, most recently
from
c34eef6
to
f9781dc
Compare
kschiffer
force-pushed
the
feature/713-gateway-location-settings
branch
from
8ccfa20
to
79416c3
Compare
kschiffer
changed the base branch from
feature/643-device-location-settings
to
master
bafonins
suggested changes
May 23, 2019
There was a problem hiding this comment.
only small remarks
@htdvisser do we support only a single gateway antenna?
| @connect( | ||
| ({ gateway, application }, props) => ({ | ||
| gateway: gateway.gateway, | ||
| application: application.application, |
| @@ -13,6 +13,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| /* eslint-disable no-invalid-this */ | |||
| /* eslint-disable array-callback-return */ | |||
There was a problem hiding this comment.
is this because of how traverse works?
There was a problem hiding this comment.
Yes. It uses a mapping function that does not expect a return value which will cause the linter to nag.
We agreed to have only one antenna location for MVP on slack. |
kschiffer
force-pushed
the
feature/713-gateway-location-settings
branch
from
79416c3
to
70cfb29
Compare
bafonins
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #713
Dependent on #643 (hence draft PR)Changes
Notes for Reviewers
Complementary implementation to #643.
Release Notes