Gateway General Settings Page #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
suggested changes
May 28, 2019
| error: '', | ||
| initialValues: {}, | ||
| mapErrorsToFields: {}, | ||
| formRef: undefined, |
There was a problem hiding this comment.
Suggested change
| formRef: undefined, |
?
| }, | ||
| dispatch => ({ | ||
| onDeleteSuccess: () => dispatch(replace('/console/gateways')), | ||
| updateGateway: (id, patch) => dispatch(updateGateway(id, patch)), |
There was a problem hiding this comment.
Suggested change
| updateGateway: (id, patch) => dispatch(updateGateway(id, patch)), | |
| updateGateway, |
| <Row> | ||
| <Col lg={8} md={12}> | ||
| <IntlHelmet | ||
| title={sharedMessages.addGateway} |
There was a problem hiding this comment.
Suggested change
| title={sharedMessages.addGateway} | |
| title={sharedMessages.generalSettings} |
bafonins
force-pushed
the
feature/749-gateway-general-settings
branch
from
1adffa6
to
341cab2
Compare
kschiffer
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #749
This PR adds the Gateway General Settings Page
Changes
<GatewayDataForm /><GatewayGeneralSettigns /><GatewayAdd />Notes for Reviewers
Is it fine to put the form to
/console/componentsor is it more suitable forcontainers?Release Notes