Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General webui styling polish and fixes #923

Merged
merged 30 commits into from
Jul 3, 2019

Conversation

kschiffer
Copy link
Member

Summary

Closes #921

Changes

  • Add a subtle gradient to the header component (according to screen design)
  • Decrease logo size (to match screen design)
  • Fine tune spacing in the navbar (to match screen design)
  • Fix icon color sometimes being 100% black
  • Fix styling of the sidebar (to match screen design)
  • Fix container width of the grid system (to be more considerate of the console layout)
  • Fix layout of radio-button/checkbox group items, to allow proper line-wrapping of items in smaller layouts
  • Fix / prevent overflow of breadcrumbs (by collapsing crumbs in smaller screens)
  • Remove profile picture placeholder in the header for the time being
  • Add a general bottom padding to the app container, to prevent content touching the footer
  • Streamline table layout for entities (text, title usage, column layout)
  • Improve empty table message (better (generalized) text, more subtle appearance)
  • Fix scrolling behavior of the console layout (footer should be fixed at the viewport bottom, content should scroll inside the content section only)
  • Various tiny fixes to bring the layout closer to the screen design

Notes for Reviewers

This is lot's of individual small fixes. Might be best to go through commit by commit, instead of via the whole diff.

@kschiffer kschiffer added the c/console This is related to the Console label Jul 3, 2019
@kschiffer kschiffer added this to the July 2019 milestone Jul 3, 2019
@kschiffer kschiffer requested a review from bafonins July 3, 2019 13:31
@kschiffer kschiffer self-assigned this Jul 3, 2019
@kschiffer kschiffer changed the title Feature/921 general styling polish General webui styling polish and fixes Jul 3, 2019
@kschiffer kschiffer force-pushed the feature/921-general-styling-polish branch from 48a1329 to 40d9cf8 Compare July 3, 2019 13:58
@kschiffer kschiffer mentioned this pull request Jul 3, 2019
48 tasks
@kschiffer kschiffer merged commit 55cb072 into master Jul 3, 2019
@kschiffer kschiffer deleted the feature/921-general-styling-polish branch July 3, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webui general styling polish and fixes
2 participants