Fix/instruction counter #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore generated class files, eclipse project files
|
Great work. This definitely fixes the first half of #21. I realized when reviewing this that Would you like to also add support for the R4 format? If not, I'll merge in your changes as is and add it myself. |
|
Sure. Sorry I haven't read about the F extension till short before, so I skipped it. |
|
Thanks for the quick response. Just for future reference, you don't need to close a Pull Request and make a new one to update it. You should be able to see ef7286a in the list of commits on this page. |
|
Oh, I see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified InstructionCounter Tool to support B and J-type instruction count.