Manual Installation (iOS) - Update onVideoSaved #1346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add proptype func for onVideoSaved method
|
looks like this was because I was using the wrong package version for my RN version (0.55). downgrading to 3.2.1 works fine 👍 I hope this helps someone else in the future |
|
It looks like this was left over from some of the work done on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this missing proptype was throwing an error with the packager, not sure if this is because I elected to manually install instead of taking the cocoa pods route. in either case, there is an onVideoSaved method declaration in RCTVideoManager that I cant seem to find anywhere else (in the docs or Video.js)