Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(app): CI #26

Merged
merged 7 commits into from
Aug 18, 2023
Merged

build(app): CI #26

merged 7 commits into from
Aug 18, 2023

Conversation

juskek
Copy link
Collaborator

@juskek juskek commented Aug 18, 2023

No description provided.

@juskek juskek force-pushed the build/ci-app branch 3 times, most recently from d13452d to b357647 Compare August 18, 2023 13:29
- name: Create env file
run: |
pwd
echo "${{ secrets.FRONT_ENV_FILE }}" > .env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for CI?

Copy link
Collaborator

@Lerri-Cofannos Lerri-Cofannos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Two small questions


// Any custom config you want to pass to Jest
const customJestConfig = {
setupFilesAfterEnv: ["<rootDir>/jest.setup.js"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to link an empty file in the config?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this test be merged to main? Was it not only to test whether the CI ran when opening a PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest fails if there are no tests found - this test file will be replaced with proper tests in future tickets

@juskek juskek merged commit a39ed5d into main Aug 18, 2023
1 check passed
@juskek juskek deleted the build/ci-app branch August 18, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants