Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search bar component to the log table page #34

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

Lerri-Cofannos
Copy link
Collaborator

No description provided.

@@ -12,6 +12,6 @@
{ "max": 75, "skipBlankLines": true, "skipComments": true }
],
"complexity": ["error", 6],
"prettier/prettier": ["error", { "tabWidth": 4 }]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably still move this to a prettier file any extra configs might not be detected by vscode cause it looks at the prettierrc file for formatting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this is not necessary according to https://khalilstemmler.com/blogs/tooling/prettier/ , and it works fine on my IDE: changing the .eslintrc updates the config of my prettier's IDE suggestions

@Lerri-Cofannos Lerri-Cofannos merged commit 2898e27 into main Aug 23, 2023
1 check passed
@Lerri-Cofannos Lerri-Cofannos deleted the feat/add-searchbar-component branch August 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants