Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(sdk): add CI for GitHub Actions #36

Merged
merged 15 commits into from
Aug 24, 2023
Merged

build(sdk): add CI for GitHub Actions #36

merged 15 commits into from
Aug 24, 2023

Conversation

juskek
Copy link
Collaborator

@juskek juskek commented Aug 23, 2023 •
edited
Loading

DESTOCK:

Added:

  • Created ADR for linting in Python
  • Set up flake8 linting to check for errors
  • Set up CI to run flake8
  • Set up black to run on autosave

@juskek juskek force-pushed the build/ci-python branch 3 times, most recently from 516454b to 6fd2dbd Compare August 23, 2023 14:33
@juskek juskek force-pushed the build/ci-python branch 4 times, most recently from f9f7d96 to 1084ce3 Compare August 24, 2023 10:15
Lerri-Cofannos
Lerri-Cofannos approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@Lerri-Cofannos Lerri-Cofannos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny comment, but otherwise it's good to go!

sdk-python/.vscode/settings.json Show resolved Hide resolved
sdk-python/omnilogger/database.py Outdated Show resolved Hide resolved
@juskek juskek merged commit d7ef944 into main Aug 24, 2023
1 check passed
@juskek juskek deleted the build/ci-python branch August 24, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CallumHemsley CallumHemsley CallumHemsley approved these changes

@Lerri-Cofannos Lerri-Cofannos Lerri-Cofannos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juskek @CallumHemsley @Lerri-Cofannos