Refactor the listener to implement a decorator around openai.Completion.create #47
Conversation
Lerri-Cofannos
force-pushed
the
refactor/decorator-listener
branch
2 times, most recently
from
ad1d504
to
866cfae
Compare
|
|
||
|
|
||
| def start_openai_listener(): | ||
| openai.Completion = CustomCompletion |
There was a problem hiding this comment.
that's really neat! monkey patching 🐵
There was a problem hiding this comment.
It looks like the Completion API has been marked as legacy now. Should we be patching the ChatCompletions API instead?
There was a problem hiding this comment.
Upgrading to ChatCompletion is a refactor that would need its own ticket I believe
https://trello.com/c/rkkADWMv
There was a problem hiding this comment.
Was the usage of the Completion API intentional? Was there a reason it was implemented over other APIs?
I agree about the ticket!
There was a problem hiding this comment.
It was not intentional, just took the example off the OpenAI docs
Lerri-Cofannos
force-pushed
the
refactor/decorator-listener
branch
from
866cfae
to
3d78163
Compare
There was a problem hiding this comment.
I did not catch this earlier, but is there any reason we are using relative imports instead of absolute?
iirc relative imports are highly discouraged
There was a problem hiding this comment.
On my device absolute imports are calling the published module instead of my dev folder...
| ```sh | ||
| pyenv install 3.11.3 | ||
| poetry env use 3.11.3 | ||
| poetry install | ||
| ``` | ||
|
|
||
| 2. Generate prisma types |
|
The ticket mentions a test to delete - does that need to be done? |
No description provided.