-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add tag binding #90
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b3e7ca6
feat(front): create calls from services to tag api
Lerri-Cofannos e46f575
feat(front): add red option in button atom
Lerri-Cofannos 29d497b
feat(front): create button atom with icon
Lerri-Cofannos bb7717c
feat(front): create popup atom
Lerri-Cofannos 1d49193
feat(front): safe cast response from tagsAPI
Lerri-Cofannos bbdd338
feat(front): create tag popup
Lerri-Cofannos d09e3a9
refactor(front): move tables to views subdirectory
Lerri-Cofannos f2a7b30
fix(front): adjust getTags to server response
Lerri-Cofannos 20a1eff
style(front): improve popup UI
Lerri-Cofannos 9bcb131
refactor(front): move LogsData to prisma folder
Lerri-Cofannos 2b55f4a
fix(front): update path to LogsData in page test
Lerri-Cofannos e19a887
style(front): change ButtonIcon outline colour
Lerri-Cofannos 0b3c3c6
feat(front): improve UX speed when adding tags
Lerri-Cofannos b9af47d
refactor(front): move the propagation prevention to useTagPopup
Lerri-Cofannos 5e4824f
refactor(front): move connectTagToLog to relevant file
Lerri-Cofannos 72f975e
refactor(front): group tag helper functions
Lerri-Cofannos c64b9ee
feat(front): handle errors while connecting log and tag
Lerri-Cofannos 39034c6
fix(front): prevent adding existing tag to array
Lerri-Cofannos 4a22a4e
refactor(front): rename colour picker function
Lerri-Cofannos e800c1b
fix(front): remove unused buttons on popup
Lerri-Cofannos badbd1d
refactor(front): create closePopup func in tag hook
Lerri-Cofannos 56006ed
refactor(front): use built-in string comparison
Lerri-Cofannos dec6e0e
refactor(front): clean className string format
Lerri-Cofannos 8de6f1a
refactor(front): remove unused type option for button
Lerri-Cofannos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this colourPicker specific to the button? If so, maybe include that in the name? Before I understood the function I thought if might be better living outside this folder, but actually it's looks specific to button? Probably good to make this clear in the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add it in the name, but this function is not exported so I thought it was clear that the scope was restrained to this file. I will rename it to buttonColourPicker.