feat: setup github actions #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francisco-Costa98
force-pushed
the
ci/57-setup-ci
branch
from
f38b01c
to
7a5ce0c
Compare
juskek
approved these changes
Aug 7, 2023
| @@ -29,8 +29,5 @@ module.exports = { | |||
| rules: { | |||
| "import/order": "off", | |||
| "react-hooks/exhaustive-deps": "error", | |||
| "prettier/prettier": ["warn", { | |||
There was a problem hiding this comment.
why was this removed? this will require a change in indentation for all the files in the code base right? 😰
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "printWidth": 120, | |||
| "tabWidth": 4, | |||
There was a problem hiding this comment.
oh what is the diff between having it in eslintrc and prettierrc?
There was a problem hiding this comment.
so the prettierrc is the file that most vscodes are setup to read from when you have pritier installed
so i moved this here so my format on save could work properly and itll still match the linting
src/view/components/results/comparison/__test__/EmissionsComparison.test.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.