Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Improve coverage #9

Merged
merged 6 commits into from
Apr 11, 2020
Merged

BUGFIX: Improve coverage #9

merged 6 commits into from
Apr 11, 2020

Conversation

ThibTrip
Copy link
Owner

@ThibTrip ThibTrip commented Apr 11, 2020

Improved bad coverage due to using pytest multiple times and then calling codecov instead of just a single pytest and then codecov.

@ThibTrip ThibTrip changed the title BUGFIX: Fix coverage BUGFIX: Improve coverage Apr 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #9 into master will increase coverage by 12.53%.
The diff coverage is 96.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   76.99%   89.53%   +12.53%     
===========================================
  Files          12       12               
  Lines         526      535        +9     
===========================================
+ Hits          405      479       +74     
+ Misses        121       56       -65     
Impacted Files Coverage Δ
pangres/tests/conftest.py 96.96% <93.75%> (-3.04%) ⬇️
pangres/examples.py 100.00% <100.00%> (ø)
pangres/tests/test_chunsize.py 100.00% <100.00%> (ø)
pangres/tests/test_pandas_special_engine.py 100.00% <100.00%> (ø)
pangres/tests/test_upsert.py 100.00% <100.00%> (+11.11%) ⬆️
pangres/tests/test_upsert_speed.py 74.19% <100.00%> (ø)
pangres/helpers.py 89.83% <0.00%> (+7.34%) ⬆️
pangres/tests/test_index.py 96.55% <0.00%> (+13.79%) ⬆️
pangres/utils.py 80.00% <0.00%> (+57.14%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99873f3...8345683. Read the comment docs.

@ThibTrip ThibTrip merged commit dc2c7aa into master Apr 11, 2020
@ThibTrip ThibTrip deleted the fix_coverage branch April 11, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants