Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to dock_from_renv function #60

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

campbead
Copy link
Contributor

adding flag to dock_from_renv function, keep_renv_version to allow the dockerfile to use the same version of renv as specified in the lockfile.

See issue 59

@VincentGuyader
Copy link
Member

I'm not sure if the default parameters should be FALSE or TRUE here...

I have to think about it.

@VincentGuyader VincentGuyader changed the base branch from master to new1 October 29, 2023 13:08
@VincentGuyader VincentGuyader merged commit e3222d4 into ThinkR-open:new1 Oct 29, 2023
0 of 5 checks passed
VincentGuyader added a commit that referenced this pull request Oct 29, 2023
* add Dockerfile parser (#55)

* add Dockerfile parser

* add parsing test

* add flag to dock_from_renv function (#60)

* add keep_renv_version flag to dock_from_renv function and associated test

* fixed typo

* Update dock_from_renv.R

* improve dock_from_renv

* flat_ file correction

* it's always a typo

---------

Co-authored-by: Josiah Parry <[email protected]>
Co-authored-by: Adam J Campbell <[email protected]>
@VincentGuyader
Copy link
Member

@campbead I made some modifcation about the parameters (and because now we use a bundelised {renv} inside {dockerfiler}
see :


#' @param renv_version character. The {renv} version to use in the generated Dockerfile. 
#' By default, it is set to the version specified in the `renv.lock` file. 
#' If the `renv.lock` file does not specify a {renv} version, the version of {renv} bundled with {dockerfiler}, specifically `dockerfiler::renv$the$metadata$version`, will be used. If you set it to NULL, the latest available version of {renv} will be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants