Increase test covr. for with_opt.R from 22.58% to 100% [FR]
#1065
Labels
enhancement
New feature or request
Comments
5 tasks
ilyaZar
added a commit
to ilyaZar/golem
that referenced
this issue
Jul 6, 2023
- change filename: testthat style suggets "test-with_opt.R" to test functions in a file named "with_opt.R" - improve tests for maintenance mode to see whether it works with setting options in a fresh golem - add tests for SHINY_PORT Refs: ThinkR-open#1065
ilyaZar
added a commit
to ilyaZar/golem
that referenced
this issue
Jul 7, 2023
- change filename: testthat style suggets naming "tests/test-with_opt.R" to test functions in a file named "R/with_opt.R" - improve tests for maintenance mode to see whether it works with setting options in a fresh golem - add tests for "SHINY_PORT" Refs: ThinkR-open#1065
VincentGuyader
pushed a commit
that referenced
this issue
Aug 8, 2023
* tests: add tests to increase test coverage - change filename: testthat style suggets naming "tests/test-with_opt.R" to test functions in a file named "R/with_opt.R" - improve tests for maintenance mode to see whether it works with setting options in a fresh golem - add tests for "SHINY_PORT" Refs: #1065 * tests: add tests to further increase coverage Add a test for get_golem_options() function which was untested before. * tests: test with_golem_options() with print=TRUE - formatting with grk - update comments to explain the test - update the SHINY_PORT test to actually test the behaviour properly - add a new test to check whether print=TRUE works inside with_golem_options()
VincentGuyader
added a commit
that referenced
this issue
Aug 8, 2023
…1080) * tests: add tests to increase test coverage - change filename: testthat style suggets naming "tests/test-with_opt.R" to test functions in a file named "R/with_opt.R" - improve tests for maintenance mode to see whether it works with setting options in a fresh golem - add tests for "SHINY_PORT" Refs: #1065 * tests: add tests to further increase coverage Add a test for get_golem_options() function which was untested before. * tests: test with_golem_options() with print=TRUE - formatting with grk - update comments to explain the test - update the SHINY_PORT test to actually test the behaviour properly - add a new test to check whether print=TRUE works inside with_golem_options() Co-authored-by: Ilya Zarubin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
No specific bug, but increasing the code coverage for this file might be generally useful since it has functions that the user interacts with.
Describe the solution you'd like
Add tests so that coverage is 100%.
Additional context
Can be fixed via #1066
The text was updated successfully, but these errors were encountered: