Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] add_dockerfile_with_renv doesnt work if golem names as uppercase #944

Closed
VincentGuyader opened this issue Dec 1, 2022 · 0 comments
Closed

[BUG] add_dockerfile_with_renv doesnt work if golem names as uppercase #944

VincentGuyader opened this issue Dec 1, 2022 · 0 comments
Assignees
@ColinFay
Labels
bug Something isn't working

Comments

@VincentGuyader
Copy link
Member

Describe the bug

if golem names is UPPERCASE
then it will procude this,

docker build -f Dockerfile_base --progress=plain -t UPPERCASE .

which is not possible

To Reproduce
golem::create_golem(path = "UPPERCASE")
golem::add_dockerfile_with_renv(output_dir = "deploy")
@VincentGuyader VincentGuyader added the bug Something isn't working label Dec 1, 2022
VincentGuyader added a commit that referenced this issue Dec 2, 2022
@VincentGuyader
fix #944
22a50a1 
for lowercase for pacakge name in Dockerfile
@VincentGuyader VincentGuyader mentioned this issue Dec 7, 2022
Merged
VincentGuyader added a commit that referenced this issue Dec 7, 2022
@VincentGuyader
Fix 944 and correct CI (#947)
acc054b 
* fix #944

force lowercase for package name in Dockerfile

* check_is_installed is back again instead of fs_file_copy for dockerfile creation 

* set version to 0.3.5.9001
@VincentGuyader VincentGuyader mentioned this issue Jan 19, 2023
Closed
ColinFay pushed a commit that referenced this issue Mar 10, 2023
@VincentGuyader @ColinFay
Fix 944 and correct CI
08f050f 
* fix #944

force lowercase for package name in Dockerfile

* check_is_installed is back again instead of fs_file_copy for dockerfile creation

* set version to 0.3.5.9001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ColinFay ColinFay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VincentGuyader @ColinFay