Fix 1031 #1063
Closed
Fix 1031 #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add chunk inside R/03_deploy.R that has the relevant call to rsconnect::writeManifest - while already here: update file with RStudio -> Posit - some styling (--- for code folding and re-group function calls a bit)
- consistent code formatting with `` - some typos - remove some redundant whitespace - Remove double "####" headers in a row - update with rsconnect::writeManifest() information
ColinFay
changed the base branch from
dev
to
temp-branch-for-cherry-pick-1063
|
I've cherry-picked and merged to https://github.com/ThinkR-open/golem/tree/1063-cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1031
Just to make sure I do not miss anything @jdavis-EliLilly , is it just this one-liner here?
golem/inst/shinyexample/dev/03_deploy.R
Lines 40 to 42 in 1ce2d5c
From the documentation I understand that
rsconnect::writeManifest()is for repeated usage, similar torsconnect::deployApp()for repeated deployment (whereas the other functions in the file are usually called once for file creation only). So I would think this is a reasonable place for thersconnect::writeManifest()call, or?