Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): unifying config manipulation #876

Merged
merged 57 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
19c49dd
fix(config): unifying config manipulation
ColinFay Jul 2, 2022
d2554bc
fix(CI): correct path check
ColinFay Jul 2, 2022
7ab7efa
fix(typo): pkg_path instead of golem_path
ColinFay Jul 2, 2022
b79c7b3
feature(creation): create golem only set the app name
ColinFay Jul 2, 2022
f793017
feat(create_golem): No name change in the YAML
ColinFay Jul 2, 2022
818987a
fix(option-setting): don't change to expr before passing to set_golem…
ColinFay Jul 2, 2022
3f9fcb3
chore(file): file splitting & renaming
ColinFay Jul 4, 2022
a7c04cf
fix(config): Use the correct env var in get_golem_*
ColinFay Jul 4, 2022
b420bd5
fix(config): golem_wd is now golem::pkg_path()
ColinFay Jul 4, 2022
411f952
chore(style): Change the indentation of param
ColinFay Jul 4, 2022
30ec5d2
feat(config): get_golem_* now tries to guess if not found in yaml
ColinFay Jul 4, 2022
05033a3
fix(test): no recommended tests
ColinFay Jul 5, 2022
c07cf9c
feat(config): get_current_config no longer set options
ColinFay Jul 5, 2022
709a382
feat: add support for docker & {renv} (#882)
VincentGuyader Jul 13, 2022
5004b04
Merge branch 'dev' into master
ColinFay Aug 8, 2022
210db93
feat: add support for docker & {renv} (#882) (#889)
ColinFay Aug 8, 2022
fe1d12d
doc: bump dev version
ColinFay Aug 8, 2022
8b22ea8
bug: fixed bug with check_installed
ColinFay Aug 8, 2022
cc2ba3d
chore: added an EOF
ColinFay Aug 8, 2022
853790d
Merge branch 'dev' of https://github.com/ThinkR-open/golem into dev
ColinFay Aug 8, 2022
9d51302
chore: reindent
ColinFay Aug 8, 2022
75ee807
chore: changed indentatino
ColinFay Aug 8, 2022
828f3de
fix(DESCRIPTION): typo in version number
ColinFay Aug 9, 2022
a6ac858
chore: added some comments
ColinFay Aug 9, 2022
3ba39ee
doc: re-built the doc
ColinFay Aug 9, 2022
b556255
fix: issue with param names
ColinFay Aug 9, 2022
0598cae
refactor: explicitly set arguments
ColinFay Aug 9, 2022
6827572
fix: removed unused argument
ColinFay Aug 9, 2022
ffb491c
doc(vignette): renames the title according to convention
ColinFay Aug 9, 2022
48f78fe
fix: correct handling of paths in yaml-set
ColinFay Aug 9, 2022
d6b5670
fix(config): unifying config manipulation
ColinFay Jul 2, 2022
4d3a5bb
fix(CI): correct path check
ColinFay Jul 2, 2022
6aa325f
fix(typo): pkg_path instead of golem_path
ColinFay Jul 2, 2022
70d2471
feature(creation): create golem only set the app name
ColinFay Jul 2, 2022
9a988e2
feat(create_golem): No name change in the YAML
ColinFay Jul 2, 2022
ca5a007
fix(option-setting): don't change to expr before passing to set_golem…
ColinFay Jul 2, 2022
ddf241c
chore(file): file splitting & renaming
ColinFay Jul 4, 2022
6615842
fix(config): Use the correct env var in get_golem_*
ColinFay Jul 4, 2022
4e221a6
fix(config): golem_wd is now golem::pkg_path()
ColinFay Jul 4, 2022
15df875
chore(style): Change the indentation of param
ColinFay Jul 4, 2022
1b92965
feat(config): get_golem_* now tries to guess if not found in yaml
ColinFay Jul 4, 2022
feda561
fix(test): no recommended tests
ColinFay Jul 5, 2022
e5df612
feat(config): get_current_config no longer set options
ColinFay Jul 5, 2022
a386650
chore: changed indentatino
ColinFay Aug 8, 2022
4472ae0
chore: added some comments
ColinFay Aug 9, 2022
57869e4
fix: issue with param names
ColinFay Aug 9, 2022
78ae7a7
refactor: explicitly set arguments
ColinFay Aug 9, 2022
bdc2b4f
fix: removed unused argument
ColinFay Aug 9, 2022
e21105a
doc(vignette): renames the title according to convention
ColinFay Aug 9, 2022
0d7f6ae
fix: correct handling of paths in yaml-set
ColinFay Aug 9, 2022
c176cb3
Merge branch 'issue-709-reborn' of https://github.com/ThinkR-open/gol…
ColinFay Aug 9, 2022
0171378
doc: documentation update for new params in funs
ColinFay Aug 9, 2022
61ad01c
doc: moved {here} to Suggests
ColinFay Aug 9, 2022
c2907e3
doc: funs documented & param names
ColinFay Aug 9, 2022
d4fc8f8
fix: issue with pkg_path when not in project
ColinFay Aug 11, 2022
45b3e20
709 win (#904)
VincentGuyader Aug 17, 2022
f7fdf74
fix: add normalizePath() inside set_golem_wd() check() (#908)
VincentGuyader Aug 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: golem
Title: A Framework for Robust Shiny Applications
Version: 0.3.2.9004
Version: 0.3.3.9000
Authors@R:
c(person(given = "Colin",
family = "Fay",
Expand Down Expand Up @@ -54,8 +54,8 @@ Imports:
config,
crayon,
desc,
fs,
here,
fs,
htmltools,
rlang,
rstudioapi,
Expand All @@ -66,7 +66,7 @@ Imports:
Suggests:
covr,
devtools,
dockerfiler (>= 0.1.4),
dockerfiler (>= 0.2.0),
knitr,
pkgload,
pkgbuild,
Expand All @@ -82,11 +82,11 @@ Suggests:
testthat,
tools,
withr,
attachment
attachment (>= 0.2.5)
VignetteBuilder:
knitr
Config/testthat/edition: 3
Encoding: UTF-8
Language: en-US
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.2
RoxygenNote: 7.2.1
4 changes: 4 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ export(add_css_file)
export(add_dockerfile)
export(add_dockerfile_heroku)
export(add_dockerfile_shinyproxy)
export(add_dockerfile_with_renv)
export(add_dockerfile_with_renv_heroku)
export(add_dockerfile_with_renv_shinyproxy)
export(add_fct)
export(add_html_template)
export(add_js_file)
Expand Down Expand Up @@ -37,6 +40,7 @@ export(expect_shinytag)
export(expect_shinytaglist)
export(favicon)
export(fill_desc)
export(get_current_config)
export(get_golem_name)
export(get_golem_options)
export(get_golem_version)
Expand Down
11 changes: 10 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
> Notes: the # between parenthesis referes to the related issue on GitHub, and the @ refers to an external contributor solving this issue.

# golem 0.3.2.9000+
# golem 0.3.3.9000+

### Soft deprecated

Expand All @@ -25,6 +25,15 @@

## Internal changes

# golem 0.3.3

## New functions

+ `add_dockerfile_with_renv()`, `add_dockerfile_with_renv_heroku()` and `add_dockerfile_with_renv_shinyproxy()` build Dockerfiles that rely on `{renv}`

### Soft deprecated

+ `add_dockerfile`, `add_dockerfile_shinyproxy()` and `add_dockerfile_heroku()` now recommend to switch to their `_with_renv_` counterpart


# golem 0.3.2 (CRAN VERSION)
Expand Down
Loading