Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add normalizePath() inside set_golem_wd() check() #908

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

VincentGuyader
Copy link
Member

@VincentGuyader VincentGuyader commented Aug 18, 2022

  • There was an issue with comparison of path on windows (issue with / & \

  • Force daf_desc to return string instead of a factor

@ColinFay ColinFay changed the title add normalizePath everywhere for #709 fix: add normalizePath() inside set_golem_wd() check(). Aug 18, 2022
@ColinFay ColinFay changed the title fix: add normalizePath() inside set_golem_wd() check(). fix: add normalizePath() inside set_golem_wd() check() Aug 18, 2022
@ColinFay ColinFay merged commit f7fdf74 into issue-709-reborn Aug 18, 2022
@ColinFay ColinFay deleted the 709-again branch February 28, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants