Update SessionService to use $state instead of $location #3030
Labels
Comments
bors bot
added a commit
that referenced
this issue
Aug 30, 2018
3041: refractor(session service) using $state instead of $location r=jniles a=jeremielodi closes #3030 3094: fix: migrate to utf8mb4 r=jniles a=jniles This commit migrates the database to UTF8MB4 in preparation for MySQL 8 which defaults to this. It also produces better results for diverse character sets. Closes #2989. **Overview** The motivation for this Pull Request is two-fold: 1. Make sure no one had [break the server](https://medium.com/@adamhooper/in-mysql-never-use-utf8-use-utf8mb4-11761243e434) by putting valid characters that [cannot be represented in MySQL's UTF8 character set](https://stackoverflow.com/questions/30074492/what-is-the-difference-between-utf8mb4-and-utf8-charsets-in-mysql#30074553). 2. Ensure we are set up for future releases of MySQL and future languages by migrating to UTF8MB4. MySQL 8 will support this out of the box. And additional benefit continues the work started by @mbayopanda in his work on Travis CI changes in #3061 to document and standardize the character sets and collations in our database. Previously, we just relied on having "the right set up", with some of our Stored Procedures in the server's default encoding, functions called in the mysqljs's default encoding, etc... Now, we define at creation time and connection time the character sets and collations we are working with. **Notes** I had to [skip one test](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/test/end-to-end/verificationLinks/verificationLinks.spec.js#L19). It was the link between debtor groups and patients. I'm pretty sure this is due to the fact that the order data was inserted in changed somehow. Either way, the test is non-specific and should be re-written to reference the group by its name. Co-authored-by: jeremielodi <[email protected]> Co-authored-by: Jonathan Niles <[email protected]>
bors bot
added a commit
that referenced
this issue
Aug 30, 2018
3041: refractor(session service) using $state instead of $location r=jniles a=jeremielodi closes #3030 Co-authored-by: jeremielodi <[email protected]>
bors bot
added a commit
that referenced
this issue
Sep 3, 2018
3041: refractor(session service) using $state instead of $location r=jniles a=jeremielodi closes #3030 Co-authored-by: jeremielodi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
SessionServicemanages the user's session on the client. When the session is logged out, the service redirects the user to the/loginURL using $location. Since we've mostly lifted navigation from angular's$locationservice to use ui-router's$stateservice, it would make sense that we also switch these calls to using$statefor uniformity.The text was updated successfully, but these errors were encountered: