Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include actual and expected hash in migration validation error message #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ export function validateMigrationHashes(
const invalidHashes = migrations.filter(invalidHash)
if (invalidHashes.length > 0) {
// Someone has altered one or more migrations which has already run - gasp!
const invalidFiles = invalidHashes.map(({fileName}) => fileName)
throw new Error(`Hashes don't match for migrations '${invalidFiles}'.
This means that the scripts have changed since it was applied.`)
const errors = invalidHashes
.map(migration => `Migration failed for File: ${migration.fileName}.`
+ 'This means that this script has changed since it was applied.\n\t'
+ `Expected Hash: ${appliedMigrations[migration.id].hash}\n\tActual Hash: ${migration.hash}`)
.join('\n');
throw new Error(errors);
}
}