New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request/reply support #397

Merged

roblaszczak merged 16 commits into master from request-reply-v2

Sep 24, 2023

Member

roblaszczak commented Sep 20, 2023

No description provided.

roblaszczak added 6 commits

September 20, 2023 09:18


          another try on request/reply

542def9


          inject command bus via interface

c68c0f0


          add notification id to params


          update request/reply

868fda4


          added requestreply docs

71e48c6


          fix lint

ed51c20

roblaszczak marked this pull request as ready for review

September 23, 2023 11:38


          fix flaky test

0eb2352

roblaszczak mentioned this pull request

Does watermill supports request reply pattern using NATS ? #299

Open


          more docs

d91c564

m110 reviewed

View reviewed changes

components/requestreply/backend_pubsub.go Show resolved Hide resolved

components/cqrs/command_processor.go Show resolved Hide resolved

m110 reviewed

View reviewed changes

components/requestreply/requestreply.go Outdated Show resolved Hide resolved


          Update components/requestreply/requestreply.go

3daccf0

m110 reviewed

View reviewed changes

components/requestreply/requestreply.go Outdated Show resolved Hide resolved


          Update components/requestreply/requestreply.go

f679266

m110 reviewed

View reviewed changes

components/requestreply/handler.go Outdated Show resolved Hide resolved


          Update components/requestreply/handler.go

28d4b04

m110 reviewed

View reviewed changes

components/requestreply/handler.go Outdated Show resolved Hide resolved

m110 reviewed

View reviewed changes

components/requestreply/handler.go Outdated Show resolved Hide resolved


          Update components/requestreply/handler.go

f13fca5

m110 reviewed

View reviewed changes

components/requestreply/handler.go Outdated Show resolved Hide resolved


          Update components/requestreply/handler.go

b991d68

m110 reviewed

View reviewed changes

components/requestreply/command_bus.go Outdated Show resolved Hide resolved


          Update components/requestreply/command_bus.go

345039d

m110 reviewed

View reviewed changes

components/requestreply/backend_pubsub_marshaler.go Outdated Show resolved Hide resolved

m110 reviewed

View reviewed changes

components/requestreply/command_bus.go Show resolved Hide resolved

m110 reviewed

View reviewed changes

components/requestreply/backend_pubsub.go Show resolved Hide resolved

m110 reviewed

View reviewed changes

components/cqrs/command_processor.go Outdated Show resolved Hide resolved

roblaszczak added 2 commits

September 24, 2023 22:16


          apply code review comments

0e53171


          Merge remote-tracking branch 'origin/request-reply-v2' into request-r…

2c48710

…eply-v2

# Conflicts:
#	components/requestreply/command_bus.go

m110 approved these changes

View reviewed changes

roblaszczak merged commit c77ca10 into master

6 checks passed

mamyn0va commented Oct 23, 2023

Hi @roblaszczak, do you known when the request/reply feature will be released ? Is there any related doc ?

m110 mentioned this pull request

Added request-reply support for commands #366

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet