Added lock for message.Router.middlewares #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 66.88% 66.96% +0.07%
==========================================
Files 64 64
Lines 4282 4289 +7
==========================================
+ Hits 2864 2872 +8
Misses 1242 1242
+ Partials 176 175 -1 ☔ View full report in Codecov by Sentry. |
|
Thanks @SargtLa! |
thejoeejoee
pushed a commit
to thejoeejoee/watermill
that referenced
this pull request
Sep 5, 2024
Co-authored-by: Lara Blyshchyk <[email protected]> Co-authored-by: Miłosz Smółka <[email protected]>
exasyvetde
pushed a commit
to exasyvetde/watermill
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have faced the race condition here when I was adding a handler with handler middleware while some concurrent process was calling RunHandlers. It is specified that RunHandlers is idempotent and there are locks for handlers, but not for middlewares.
Fixes #466