This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Make copies of default values to TPayload objects #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the same object is used across TPayload objects, mutating that field will affect subsequent TPayload object instances.
|
@lxyu I've added a test to make it explicit that TPayload.init must support positional args. TException is called several times with only positional args. Elsewhere in the code |
mrterry
force-pushed
the
mutable_default
branch
from
cf6678d
to
3ad084f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same object is used across TPayload objects, mutating that field
will affect subsequent TPayload object instances.
closes #261