This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Fix ascii error when thrift file has chinese chars. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralla
reviewed
Nov 30, 2017
| @@ -540,7 +540,7 @@ def parse(path, module_name=None, include_dirs=None, include_dir=None, | |||
| with open(urlparse(path).netloc + urlparse(path).path) as fh: | |||
| data = fh.read() | |||
| elif url_scheme == '': | |||
| with open(path) as fh: | |||
| with open(path, encoding='utf-8') as fh: | |||
There was a problem hiding this comment.
py2.7 has no keyword argument encoding. So maybe it's better to read the file in binary mode and decode it to utf-8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.