Adds Cycle Icons, Decklist Dual-Columns on Non-Default Views #875
Conversation
In addition to existing icons, this adds Cycle icons, faithfully recreated from the back of each chapter pack above the barcode area. Eventually hope to add this to deck and individual card views. It also adds column-count reflow for non-default decklist Print styleshets.
|
I tried to use the same character codes \e*** for each existing icon in CSS but, as the class names should be the same, it shouldn't cause issues as the css and fonts were generated in iconmoon.io |
…accessible Just discovered this bug which makes the footer inaccessible to clicks for the About API Donators Clear Data row. For some reason, switching from col-xs-# to col-md-# enables me to click the links. Let's get that donators link working.
|
There's a minor bug in the site footer template where About, API, Donators, and Clear Data can't be clicked if occupying a half screen. This will set it as a block for md and under. |
assets/css/icons.css
Outdated
| font-weight: normal; | ||
| font-style: normal; | ||
| font-family: 'thronesdb'; | ||
| src: url('fonts/thronesdb.eot?pg0qpl'); |
There was a problem hiding this comment.
this change breaks the path to the font file (same with the src:url(...) entries below. please revert the path changes, thanks.
assets/css/icons.css
Outdated
| font-variant: normal; | ||
| text-transform: none; | ||
| line-height: 1; | ||
| .icon { |
There was a problem hiding this comment.
this change is the right move, however it breaks the iconography in the deck builder, potentially in other places too (to be seen).
correcting this will require some work in the Javascript and template files , basically everywhere we have use any of the icon-* classes they need to be accompanies by icon.
e.g. class="icon-baratheon" renders garbage -> this will have to be class="icon icon-baratheon" instead.
There was a problem hiding this comment.
files containing icon-*classes that may have to be adjusted for this change to happen.
stefan@nichtsnutz: ~/dev/projects/thronesdb on master[$]
$ grep -lr 'icon-' assets/js/
assets/js/app.format.js
assets/js/app.deck_charts.js
assets/js/ui.deckedit.js
assets/js/ui.card.js
assets/js/ui.decklist.js
assets/js/app.deck.js
assets/js/ui.decklist_edit.js
assets/js/translations/messages/es.json
assets/js/translations/messages/en.js
assets/js/translations/messages/en.json
assets/js/translations/messages/es.js
assets/js/app.textcomplete.js
stefan@nichtsnutz: ~/dev/projects/thronesdb on master[$]
$ grep -lr 'icon-' templates/
templates/Decklist/decklist.html.twig
templates/macros.html.twig
templates/base.html.twig
templates/Default/rulesreference.en.html.twig
templates/Default/index.html.twig
templates/Default/rulesreference.es.html.twig
templates/Default/recent_reviews.html.twig
templates/Reviews/reviews.html.twig
templates/Restrictions/cardlist.html.twig
templates/Restrictions/podlist.html.twig
templates/Search/card-faction.html.twig
templates/Search/searchform.html.twig
templates/Search/display-spoiler.html.twig
templates/Search/display-list.html.twig
templates/Search/card-props.html.twig
templates/Search/display-card-reviews.html.twig
templates/Search/card-name-with-link.html.twig
templates/Search/card-name.html.twig
templates/Security/login.html.twig
|
@davidagnome i'm happy to take it from here and make this work. might be a couple of works - i'm close to going on vacation. |
In addition to existing icons, this adds Cycle icons, faithfully recreated from the back of each chapter pack above the barcode area. Eventually hope to add this to deck and individual card views.
It makes #874 redundant -- by incorporating the column-count reflow for non-default decklist Print stylesheets.