Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saferpay api update 1.23 => 1.31 #91

Merged
merged 7 commits into from
Jun 15, 2024

Conversation

giriroub
Copy link
Contributor

@giriroub giriroub commented Jun 4, 2024

Closes #60, #61, #62, #63, #64, #71, #72, #73

This PR contains all changes from 1.23 to 1.31, according to http://saferpay.github.io/jsonapi/#changelog

* changes according to http://saferpay.github.io/jsonapi/#v1.24.0.0.20210914

Closes: Ticketpark#60

BREAKING-CHANGE: replaced Notification->notifyUrl with Notification->successNotifyUrl and Notification->failNotifyUrl
* changes according to http://saferpay.github.io/jsonapi/#v1.26.0.0.20220118

Closes: Ticketpark#62

BREAKING-CHANGE: replaced AddressForm->display with AddressForm->addressSource
…>isB2B

* the Order property in RiskFactors is invalid, it should be IsB2B.

BREAKING-CHANGE: replaced invalid RiskFactors->order with RiskFactors->isB2B
* changes according to http://saferpay.github.io/jsonapi/#v1.30.0.0.20220920
* 1.29 and 1.31 do not contain any API interface changes

Closes: Ticketpark#71, Ticketpark#72, Ticketpark#73
@sprain sprain merged commit 8581fb4 into Ticketpark:master Jun 15, 2024
11 checks passed
@sprain
Copy link
Contributor

sprain commented Jun 15, 2024

Thank you very much for this valuable contribution!

I added some more changes in #93 (mostly replaced serializer types with native property types) and merged this. If you want, you are welcome to take the current master branch on a test drive as a potential v5.0 of this library.

@giriroub
Copy link
Contributor Author

giriroub commented Jun 17, 2024

If you want, you are welcome to take the current master branch on a test drive as a potential v5.0 of this library.

We are directly testing https://github.com/i-web/SaferpayJsonApi/tree/Saferpay-Api-Update-BC this week (we need 1.37 because of the new PaymentMethod POSTFINANCEPAY) and are planning on taking it to production by the end of the week.

@sprain
Copy link
Contributor

sprain commented Jun 21, 2024

@giriroub How did your release go?

@giriroub
Copy link
Contributor Author

The release passed all our tests, but we haven't deployed it yet. Due to other circumstances this might take another couple weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement changes of Saferpay API 1.24
2 participants