Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typing problem in advanced search filter tab #8577

Conversation

pmario
Copy link
Member

@pmario pmario commented Aug 31, 2024

This PR is related to: [BUG] Search input in "Filter" tab in advanced search drops key presses as of 5.3.5 on Firefox #8551

The text input will register fast typing again. No matter how many results are shown. So [all[]] does not cause any problems with typing anymore.

But it does not explain why there was a problem in the first place.

@hoelzro Can you check? -- As I wrote it does not explain why deleting a blank line caused the problem.

Copy link

stackblitz bot commented Aug 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

@hoelzro
Copy link
Contributor

hoelzro commented Aug 31, 2024

@pmario Thanks for looking at this - that did fix the problem! I'd like to get to the bottom of this issue all the same, though - there might be other parts of the UI that are affected.

@Jermolene
Copy link
Member

Thanks @pmario

@Jermolene Jermolene merged commit 8e1cad5 into TiddlyWiki:master Sep 1, 2024
4 checks passed
@pmario pmario deleted the advanced-search-typing-problem-simple-fix branch September 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants