Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoms relying on density() are broken #35

Closed
rdboyes opened this issue Sep 29, 2023 · 6 comments
Closed

geoms relying on density() are broken #35

rdboyes opened this issue Sep 29, 2023 · 6 comments

Comments

@rdboyes
Copy link
Member

rdboyes commented Sep 29, 2023

No description provided.

@joshualeond
Copy link

FYI, I believe I'm running into this as well: ERROR: Tuple field type cannot be Union{}

@rdboyes
Copy link
Member Author

rdboyes commented Oct 10, 2023

Yep - I get the same error when I run the equivalent algebra of graphics code though. Are you on 1.10-beta3?

@joshualeond
Copy link

Yes, I'm on 1.10.0-beta3, I haven't tried the AlgebraOfGraphics code yet. I see your issue on that side though: MakieOrg/AlgebraOfGraphics.jl#472

I'll keep an eye out on that one. Thanks!

@kdpsingh
Copy link
Member

Hi @rdboyes, it looks like this hasn't been fixed on the AoG side since the issue is still open. Once Julia 1.10 lands, does that mean this package won't work for calculating/plotting densities?

(I assume so, just seeing if we can get the Makie/AoG folks to take a look)

@rdboyes
Copy link
Member Author

rdboyes commented Dec 12, 2023

As far as I can tell, yes, that's what it means. AoG's density function won't work in 1.10 and so our calls to it won't work either. I assume AoG is going to get a major rewrite for compatibility with Makie's declarative API so they aren't updating the current code anymore

@rdboyes
Copy link
Member Author

rdboyes commented Jan 11, 2024

This is now fixed thanks to an update to AoG

@rdboyes rdboyes closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants