Support the VMware Cursor Position extension on vncviewer #1212
Conversation
lhchavez
force-pushed
the
vmware-cursor-position-vncviewer
branch
3 times, most recently
from
c41d46e
to
af439d6
Compare
vncviewer/DesktopWindow.cxx
Outdated
| #include <CoreGraphics/CGGeometry.h> | ||
| #include <CoreGraphics/CGRemoteOperation.h> |
There was a problem hiding this comment.
@CendioOssman did you get this working on macOS? or are there any further tweaks needed?
There was a problem hiding this comment.
Still gettin fatal error: CoreGraphics/CoreGraphics.h: No such file or directory. So I would still suggest the top Carbon header.
There was a problem hiding this comment.
how do you do that? i don't have a way to test these changes, so i'm flying blind.
There was a problem hiding this comment.
Just change it to #include <Carbon/Carbon.h> :)
| @@ -322,6 +332,25 @@ void DesktopWindow::setCursor(int width, int height, | |||
| } | |||
|
|
|||
|
|
|||
| void DesktopWindow::setCursorPos(const rfb::Point& pos) | |||
| { | |||
There was a problem hiding this comment.
i take the mouse-grabbing comment back, this worked!
There was a problem hiding this comment.
The grab check was fine and much welcome. My point was to also check focus. But then again, I guess grab implies focus so I guess that isn't needed...
There was a problem hiding this comment.
Ah! got it, i didn't quite grok the meaning of the other comment. Restored the grab check.
There was a problem hiding this comment.
really restored the grab check.
lhchavez
force-pushed
the
vmware-cursor-position-vncviewer
branch
from
af439d6
to
5fe485e
Compare
vncviewer/DesktopWindow.cxx
Outdated
| @@ -51,6 +51,7 @@ | |||
|
|
|||
| #ifdef __APPLE__ | |||
| #include "cocoa.h" | |||
| #include <CoreGraphics/CoreGraphics.h> | |||
There was a problem hiding this comment.
gave up trying to support individual headers and am now importing the whole thing. maybe this will alleviate the compile errors.
|
X11 seems to work fine at least. So it's Wayland and Windows that need more work. |
is there a way to check for wayland to disable it there? i'll also drop windows support since i also don't have a windows machine. |
Having support for all our platforms is a requirement unfortunately, so we need to get these resolved. I'll see if I can dig a bit more this week. |
got it, thanks! re-enabled that bit of code in the meantime. |
|
Hmm... Odd. I retested and it works just fine on Windows and Wayland now. Not sure what I did wrong before. So please put the grab check back and this is okay to merge. |
This change makes it possible for re-synchronizing the remote cursor on the vncviewer when in fullscreen mode. This is done by locally moving the cursor position to what the server thinks it should be. Now SDL games should work!
lhchavez
force-pushed
the
vmware-cursor-position-vncviewer
branch
from
7bdea1f
to
51f10f7
Compare
This change makes it possible for re-synchronizing the remote cursor on
the vncviewer when in fullscreen mode. This is done by locally moving
the cursor position to what the server thinks it should be.
Now SDL games should work!