Enable osx arm64 #82
Merged
Enable osx arm64 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2023.03.15.15.08.36
|
I think we'll need to build htslib for osx arm64 first |
awenocur
approved these changes
Mar 16, 2023
leipzig
approved these changes
Mar 16, 2023
jdblischak
reviewed
Mar 16, 2023
| @@ -11,7 +11,7 @@ source: | |||
| sha256: {{ sha256 }} | |||
|
|
|||
| build: | |||
| number: 0 | |||
| number: 1 | |||
There was a problem hiding this comment.
This will unnecessarily upload new binaries for linux, osx, and windows. The rerendering didn't change any of the pinned dependencies, so the binaries produced will be identical (or at least close to identical)
There was a problem hiding this comment.
Nevermind. In this case, where the hash of the tarball has changed, it's best to bump the build number to represent this change
jdblischak
reviewed
Mar 16, 2023
| @@ -1,6 +1,6 @@ | |||
| {% set name = "tiledb-vcf" %} | |||
| {% set version = "0.23.0" %} | |||
| {% set sha256 = "5772836d26221674d0c6fea7970a35ab2f7a2e972081c40fb1de026b7f936b0e" %} | |||
| {% set sha256 = "ac01357ed1f793fe96f728e4abb4965c7303918510cec38fda1ea5ef5ad47643" %} | |||
There was a problem hiding this comment.
Was the 0.23.0 tag moved? I'm confused why the hash has changed but not the version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable osx arm64