Use platform-specific read_at to read the files. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All frfs::File uses the same source underneath. The sources are created with try_clone. Therefore when one file is readed, all other files' cursor will be changed. This is not a desirable behavior. While there are no cross-platform way to avoid this besides reopening the source, we can use read_at/seek_read methods in the FileExt. It is a platform-specific extension, but avaliable on Windows, Unix, and WASI. The implementation on Unix of read_at is pread/pread64, and the one on Windows is NtReadFile. They are all reliable methods and will not read or write the file cursor. Using read_at, we need to manage the own offset in the frfs::File. This implementation is not suitable for try_clone. Therefore we removed this method.
4 tasks
|
Track: rust 1.66 stable release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frfs::File::try_clone。这是因为try_clone要求两个File的操作互相影响，我们反正也不需要这个功能，就删了。