This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
Add another source for groups of filters #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dafatov thanks for this fix. i made this change to the file inside my node_modules folder weeks ago. i’m surprised this hasn’t been approved. ytsr is basically unusable without it. |
|
This seems to be a good fix for this issue, thanks! @TimeForANinja mind taking a look? |
|
@TimeForANinja this is causing issues in a few projects, merging would be appreciated if all is ok. |
This was referenced Aug 11, 2023
Closed
|
thanks for the pr @dafatov |
|
🎉 This PR is included in version 3.8.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dug into the html of some search results and found that some have a list of filters hidden under popup. Actually added an additional path and an empty array, if not found at all