Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Flutter 3.3.0 + Upgrade lint package to 1.10.0 #63

Merged
merged 10 commits into from
Sep 12, 2022

Conversation

WieFel
Copy link
Member

@WieFel WieFel commented Sep 11, 2022

also moved lint dependency to dev_dependencies, as I couldn't find any reason why it was listed under normal dependencies

CHANGELOG.md Outdated Show resolved Hide resolved
@calvintam236
Copy link
Member

sdk: ">=2.12.0 <3.0.0"
should update to >=3.3.0 <4.0.0 as this blocks on flutter v3 or above and lint upgrade will break older Flutter versions.

Copy link
Member

@calvintam236 calvintam236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See converstation.

@calvintam236
Copy link
Member

sdk: ">=2.12.0 <3.0.0"

should update to >=3.3.0 <4.0.0 as this blocks on flutter v3 or above and lint upgrade will break older Flutter versions.

@WieFel don’t forget this

@calvintam236 calvintam236 added this to the v3.0.0 milestone Sep 12, 2022
@calvintam236 calvintam236 added the enhancement New feature or request label Sep 12, 2022
@WieFel
Copy link
Member Author

WieFel commented Sep 12, 2022

sdk: ">=2.12.0 <3.0.0"

should update to >=3.3.0 <4.0.0 as this blocks on flutter v3 or above and lint upgrade will break older Flutter versions.

I think putting >=3.0.0 suffices.
See
image
Lint 1.10.0 requires dart >=2.17.0 which corresponds to Flutter 3.0.0

@WieFel
Copy link
Member Author

WieFel commented Sep 12, 2022

Just noticed that setting sdk: ">=3.0.0 <4.0.0" doesn't make sense, as the sdk specifies the dart version.
Dart 3.0.0 doesn't even exist yet.

So now I set sdk: ">=2.17.0 <3.0.0" (corresponds to flutter 3.0.0) and flutter: ">=3.0.0"

@calvintam236 calvintam236 merged commit 116ffe5 into master Sep 12, 2022
@calvintam236 calvintam236 deleted the upgrade/flutter-3.3.0 branch September 12, 2022 20:41
@calvintam236
Copy link
Member

@WieFel you can now make a new release

@calvintam236
Copy link
Member

@WieFel oops, i think you forgot to update this two lines

sdk: ">=2.12.0 <3.0.0"
flutter: ">=2.0.0 <3.0.0"

@WieFel
Copy link
Member Author

WieFel commented Sep 13, 2022

I did update it. Check on master:

sdk: ">=2.17.0 <3.0.0"
flutter: ">=3.0.0"

@calvintam236
Copy link
Member

I did update it. Check on master:

sdk: ">=2.17.0 <3.0.0"
flutter: ">=3.0.0"

Not the package one. I’m referring to the example/ one.

@WieFel
Copy link
Member Author

WieFel commented Sep 14, 2022

#64

@calvintam236 calvintam236 changed the title Upgrade to flutter 3.3.0 + lint upgrade and fixes Upgrade to Flutter 3.3.0 + lint 1.10.0 Sep 15, 2022
@calvintam236 calvintam236 changed the title Upgrade to Flutter 3.3.0 + lint 1.10.0 Upgrade to Flutter 3.3.0 + Upgrade lint package to 1.10.0 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants