-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Gradle Build Chain Rework #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: GithubUpdater to make use of the new ELVersion class
Removed: .idea directory
Renamed: entitylib.java-conventions.gradle.kts -> entitylib.library-conventions.gradle.kts Switched: johnrengelman's shadow to googler's shadow fork
Tofaa2
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle Build Chain Rework
This PR overhauls the Gradle Build Chain by switching from Groovy to Kotlin DSL and introducing a
buildSrc
module. These changes enhance convenience and ease of maintenance, reducing duplicated configurations by consolidating them into convention plugins.Tasks
johnrengelman's
shadow plugin togoogler's
fork (See: Future home/support for Shadow? GradleUp/shadow#908)ELVersions
.tag_name
field from the GitHub API instead ofname
.Global Versioning
This PR introduces global versioning, allowing the update of a single version in the root
build.gradle.kts
. This update is automatically propagated throughout the project. A new task inbuildSrc
injects anELVersions
class during compilation, holding the latest version using thePEVersion
class. This class simplifies version comparison and management.Update Checker Improvements
The update checker has been refactored to:
tag_name
field from the GitHub API, ensuring compatibility when additional information is included in the title.